Commit 5cf9d706 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS: Optimise away the close-to-open getattr if there is no cached data 



If there is no cached data, then there is no need to track the file
change attribute on close.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 7cc8c5cd

fs/nfs/inode.c

+10 −3
Original line number Diff line number Diff line
@@ -761,11 +761,13 @@ EXPORT_SYMBOL_GPL(nfs_put_lock_context); 
 * @ctx: pointer to context

 * @is_sync: is this a synchronous close

 *

 * always ensure that the attributes are up to date if we're mounted

 * with close-to-open semantics

 * Ensure that the attributes are up to date if we're mounted

 * with close-to-open semantics and we have cached data that will

 * need to be revalidated on open.

 */

void nfs_close_context(struct nfs_open_context *ctx, int is_sync)

{

	struct nfs_inode *nfsi;

	struct inode *inode;

	struct nfs_server *server;
@@ -774,7 +776,12 @@ void nfs_close_context(struct nfs_open_context *ctx, int is_sync) 
	if (!is_sync)

		return;

	inode = d_inode(ctx->dentry);

	if (!list_empty(&NFS_I(inode)->open_files))

	nfsi = NFS_I(inode);

	if (inode->i_mapping->nrpages == 0)

		return;

	if (nfsi->cache_validity & NFS_INO_INVALID_DATA)

		return;

	if (!list_empty(&nfsi->open_files))

		return;

	server = NFS_SERVER(inode);

	if (server->flags & NFS_MOUNT_NOCTO)