Commit 5ce6697a authored by Martin Kaiser's avatar Martin Kaiser Committed by Lorenzo Pieralisi
Browse files

PCI: brcmstb: Remove chained IRQ handler and data in one go 

Call irq_set_chained_handler_and_data() to clear the chained handler
and the handler's data under irq_desc->lock.

See also 2cf5a03c ("PCI/keystone: Fix race in installing chained
IRQ handler").

Link: https://lore.kernel.org/r/20210115211532.19837-1-martin@kaiser.cx


Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Acked-by: default avatarNicolas Saenz Julienne <nsaenzjulienne@suse.de>
parent ff591f74

drivers/pci/controller/pcie-brcmstb.c

+1 −2
Original line number Diff line number Diff line
@@ -603,8 +603,7 @@ static void brcm_msi_remove(struct brcm_pcie *pcie) 


	if (!msi)

		return;

	irq_set_chained_handler(msi->irq, NULL);

	irq_set_handler_data(msi->irq, NULL);

	irq_set_chained_handler_and_data(msi->irq, NULL, NULL);

	brcm_free_domains(msi);

}