Commit 5ca6779d authored by Rob Clark's avatar Rob Clark
Browse files

drm/msm/devfreq: Restrict idle clamping to a618 for now 



Until we better understand the stability issues caused by frequent
frequency changes, lets limit them to a618.

Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Tested-by: default avatarJohn Stultz <john.stultz@linaro.org>
Tested-by: default avatarCaleb Connolly <caleb.connolly@linaro.org>
Link: https://lore.kernel.org/r/20211018153627.2787882-1-robdclark@gmail.com


Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent c8f01ffc

drivers/gpu/drm/msm/adreno/a6xx_gpu.c

+7 −0
Original line number Diff line number Diff line
@@ -1838,6 +1838,13 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev) 
			adreno_cmp_rev(ADRENO_REV(6, 3, 5, ANY_ID), info->rev)))

		adreno_gpu->base.hw_apriv = true;



	/*

	 * For now only clamp to idle freq for devices where this is known not

	 * to cause power supply issues:

	 */

	if (info && (info->revn == 618))

		gpu->clamp_to_idle = true;



	a6xx_llc_slices_init(pdev, a6xx_gpu);



	ret = a6xx_set_supported_hw(&pdev->dev, config->rev);

drivers/gpu/drm/msm/msm_gpu.h

+4 −0
Original line number Diff line number Diff line
@@ -203,6 +203,10 @@ struct msm_gpu { 
	uint32_t suspend_count;



	struct msm_gpu_state *crashstate;



	/* Enable clamping to idle freq when inactive: */

	bool clamp_to_idle;



	/* True if the hardware supports expanded apriv (a650 and newer) */

	bool hw_apriv;

drivers/gpu/drm/msm/msm_gpu_devfreq.c

+2 −1
Original line number Diff line number Diff line
@@ -200,6 +200,7 @@ void msm_devfreq_idle(struct msm_gpu *gpu) 


	idle_freq = get_freq(gpu);



	if (gpu->clamp_to_idle)

		msm_devfreq_target(&gpu->pdev->dev, &target_freq, 0);



	df->idle_time = ktime_get();