Commit 5ca17397 authored by Andrew Halaney's avatar Andrew Halaney Committed by Greg Kroah-Hartman
Browse files

dyndbg: make dyndbg a known cli param 



Right now dyndbg shows up as an unknown parameter if used on boot:

    Unknown command line parameters: dyndbg=+p

That's because it is unknown, it doesn't sit in the __param
section, so the processing done to warn users supplying an unknown
parameter doesn't think it is legitimate.

Install a dummy handler to register it. dynamic debug needs to search
the whole command line for modules listed that are currently builtin,
so there's no real work to be done in this callback.

Fixes: 86d1919a ("init: print out unknown kernel parameters")
Tested-by: default avatarJim Cromie <jim.cromie@gmail.com>
Signed-off-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Signed-off-by: default avatarJason Baron <jbaron@akamai.com>
Link: https://lore.kernel.org/r/1634139622-20667-2-git-send-email-jbaron@akamai.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 216a0fc4

lib/dynamic_debug.c

+12 −0
Original line number Diff line number Diff line
@@ -761,6 +761,18 @@ static __init int ddebug_setup_query(char *str) 


__setup("ddebug_query=", ddebug_setup_query);



/*

 * Install a noop handler to make dyndbg look like a normal kernel cli param.

 * This avoids warnings about dyndbg being an unknown cli param when supplied

 * by a user.

 */

static __init int dyndbg_setup(char *str)

{

	return 1;

}



__setup("dyndbg=", dyndbg_setup);



/*

 * File_ops->write method for <debugfs>/dynamic_debug/control.  Gathers the

 * command text from userspace, parses and executes it.