Commit 5c7e468a authored by Sai Krishna Potthuri's avatar Sai Krishna Potthuri Committed by Ulf Hansson
Browse files

mmc: arasan: Fix the issue in reading tap values from DT 



'of_property_read_variable_u32_array' function returns number
of elements read on success. This patch updates the condition
check in the driver to overwrite the tap values from DT if exist.

Signed-off-by: default avatarSai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
Signed-off-by: default avatarManish Narani <manish.narani@xilinx.com>
Acked-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/1623753837-21035-8-git-send-email-manish.narani@xilinx.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 4dd7080a

drivers/mmc/host/sdhci-of-arasan.c

+4 −2
Original line number Diff line number Diff line
@@ -1019,13 +1019,15 @@ static void arasan_dt_read_clk_phase(struct device *dev, 
	struct device_node *np = dev->of_node;



	u32 clk_phase[2] = {0};

	int ret;



	/*

	 * Read Tap Delay values from DT, if the DT does not contain the

	 * Tap Values then use the pre-defined values.

	 */

	if (of_property_read_variable_u32_array(np, prop, &clk_phase[0],

						2, 0)) {

	ret = of_property_read_variable_u32_array(np, prop, &clk_phase[0],

						  2, 0);

	if (ret < 0) {

		dev_dbg(dev, "Using predefined clock phase for %s = %d %d\n",

			prop, clk_data->clk_phase_in[timing],

			clk_data->clk_phase_out[timing]);