Commit 5c779702 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Takashi Iwai
Browse files

ALSA: ppc: drop if block with always false condition 



The remove callback is only called for devices that were probed
successfully before. As the matching probe function cannot complete
without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to
check this here.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Tested-by: default avatarGeoff Levand <geoff@infradead.org>
Link: https://lore.kernel.org/r/20201126165950.2554997-1-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 83ab7b45

sound/ppc/snd_ps3.c

+0 −2
Original line number Diff line number Diff line
@@ -1053,8 +1053,6 @@ static int snd_ps3_driver_remove(struct ps3_system_bus_device *dev) 
{

	int ret;

	pr_info("%s:start id=%d\n", __func__,  dev->match_id);

	if (dev->match_id != PS3_MATCH_ID_SOUND)

		return -ENXIO;



	/*

	 * ctl and preallocate buffer will be freed in