Commit 5c419366 authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

RDMA/rxe,siw: Restore uverbs_cmd_mask IB_USER_VERBS_CMD_POST_SEND 

These two drivers open code the call to POST_SEND and do not use the
rdma-core wrapper to do it, thus their usages was missed during the audit.

Both drivers use this as a doorbell to signal the kernel to start DMA.

Fixes: 628c02bf ("RDMA: Remove uverbs cmds from drivers that don't use them")
Link: https://lore.kernel.org/r/0-v1-4608c5610afa+fb-uverbs_cmd_post_send_fix_jgg@nvidia.com


Reported-by: default avatarBob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 856c2998

drivers/infiniband/sw/rxe/rxe_verbs.c

+2 −1
Original line number Diff line number Diff line
@@ -1142,7 +1142,8 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name) 
	dma_set_max_seg_size(&dev->dev, UINT_MAX);

	dma_set_coherent_mask(&dev->dev, dma_get_required_mask(&dev->dev));



	dev->uverbs_cmd_mask |= BIT_ULL(IB_USER_VERBS_CMD_REQ_NOTIFY_CQ);

	dev->uverbs_cmd_mask |= BIT_ULL(IB_USER_VERBS_CMD_POST_SEND) |

				BIT_ULL(IB_USER_VERBS_CMD_REQ_NOTIFY_CQ);



	ib_set_device_ops(dev, &rxe_dev_ops);

	err = ib_device_set_netdev(&rxe->ib_dev, rxe->ndev, 1);

drivers/infiniband/sw/siw/siw_main.c

+2 −0
Original line number Diff line number Diff line
@@ -347,6 +347,8 @@ static struct siw_device *siw_device_create(struct net_device *netdev) 
				    addr);

	}



	base_dev->uverbs_cmd_mask |= BIT_ULL(IB_USER_VERBS_CMD_POST_SEND);



	base_dev->node_type = RDMA_NODE_RNIC;

	memcpy(base_dev->node_desc, SIW_NODE_DESC_COMMON,

	       sizeof(SIW_NODE_DESC_COMMON));