Unverified Commit 5c3022e4 authored by Guo Ren's avatar Guo Ren Committed by Palmer Dabbelt
Browse files

riscv: stacktrace: Fixup ftrace_graph_ret_addr retp argument 



The 'retp' is a pointer to the return address on the stack, so we
must pass the current return address pointer as the 'retp'
argument to ftrace_push_return_trace(). Not parent function's
return address on the stack.

Fixes: b785ec12 ("riscv/ftrace: Add HAVE_FUNCTION_GRAPH_RET_ADDR_PTR support")
Signed-off-by: default avatarGuo Ren <guoren@linux.alibaba.com>
Signed-off-by: default avatarGuo Ren <guoren@kernel.org>
Link: https://lore.kernel.org/r/20221109064937.3643993-2-guoren@kernel.org


Cc: stable@vger.kernel.org
Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent cbc32023

arch/riscv/kernel/stacktrace.c

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ void notrace walk_stackframe(struct task_struct *task, struct pt_regs *regs, 
		} else {

			fp = frame->fp;

			pc = ftrace_graph_ret_addr(current, NULL, frame->ra,

						   (unsigned long *)(fp - 8));

						   &frame->ra);

		}



	}