Commit 5c152c2f authored by Mark Brown's avatar Mark Brown Committed by Catalin Marinas
Browse files

kselftest/arm64: Fix validatation termination record after EXTRA_CONTEXT 



When arm64 signal context data overflows the base struct sigcontext it gets
placed in an extra buffer pointed to by a record of type EXTRA_CONTEXT in
the base struct sigcontext which is required to be the last record in the
base struct sigframe. The current validation code attempts to check this
by using GET_RESV_NEXT_HEAD() to step forward from the current record to
the next but that is a macro which assumes it is being provided with a
struct _aarch64_ctx and uses the size there to skip forward to the next
record. Instead validate_extra_context() passes it a struct extra_context
which has a separate size field. This compiles but results in us trying
to validate a termination record in completely the wrong place, at best
failing validation and at worst just segfaulting. Fix this by passing
the struct _aarch64_ctx we meant to into the macro.

Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20220829160703.874492-4-broonie@kernel.org


Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent e40422c9

tools/testing/selftests/arm64/signal/testcases/testcases.c

+1 −1
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ bool validate_extra_context(struct extra_context *extra, char **err) 
		return false;



	fprintf(stderr, "Validating EXTRA...\n");

	term = GET_RESV_NEXT_HEAD(extra);

	term = GET_RESV_NEXT_HEAD(&extra->head);

	if (!term || term->magic || term->size) {

		*err = "Missing terminator after EXTRA context";

		return false;