Commit 5c149314 authored by Kangjie Lu's avatar Kangjie Lu Committed by David S. Miller
Browse files

net: rocker: fix a potential NULL pointer dereference 



In case kzalloc fails, the fix releases resources and returns
NOTIFY_BAD to avoid NULL pointer dereference.

Signed-off-by: default avatarKangjie Lu <kjlu@umn.edu>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4280b730

drivers/net/ethernet/rocker/rocker_main.c

+5 −0
Original line number Diff line number Diff line
@@ -2805,6 +2805,11 @@ static int rocker_switchdev_event(struct notifier_block *unused, 
		memcpy(&switchdev_work->fdb_info, ptr,

		       sizeof(switchdev_work->fdb_info));

		switchdev_work->fdb_info.addr = kzalloc(ETH_ALEN, GFP_ATOMIC);

		if (unlikely(!switchdev_work->fdb_info.addr)) {

			kfree(switchdev_work);

			return NOTIFY_BAD;

		}



		ether_addr_copy((u8 *)switchdev_work->fdb_info.addr,

				fdb_info->addr);

		/* Take a reference on the rocker device */