Commit 5c10a3db authored by Jonathan Edwards's avatar Jonathan Edwards Committed by Daniel Borkmann
Browse files

libbpf: Add extra BPF_PROG_TYPE check to bpf_object__probe_loading 

eBPF has been backported for RHEL 7 w/ kernel 3.10-940+ [0]. However only
the following program types are supported [1]:

  BPF_PROG_TYPE_KPROBE
  BPF_PROG_TYPE_TRACEPOINT
  BPF_PROG_TYPE_PERF_EVENT

For libbpf this causes an EINVAL return during the bpf_object__probe_loading
call which only checks to see if programs of type BPF_PROG_TYPE_SOCKET_FILTER
can load.

The following will try BPF_PROG_TYPE_TRACEPOINT as a fallback attempt before
erroring out. BPF_PROG_TYPE_KPROBE was not a good candidate because on some
kernels it requires knowledge of the LINUX_VERSION_CODE.

  [0] https://www.redhat.com/en/blog/introduction-ebpf-red-hat-enterprise-linux-7
  [1] https://access.redhat.com/articles/3550581



Signed-off-by: default avatarJonathan Edwards <jonathan.edwards@165gc.onmicrosoft.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20210619151007.GA6963@165gc.onmicrosoft.com
parent f42cfb46

tools/lib/bpf/libbpf.c

+4 −0
Original line number Diff line number Diff line
@@ -4000,6 +4000,10 @@ bpf_object__probe_loading(struct bpf_object *obj) 
	attr.license = "GPL";



	ret = bpf_load_program_xattr(&attr, NULL, 0);

	if (ret < 0) {

		attr.prog_type = BPF_PROG_TYPE_TRACEPOINT;

		ret = bpf_load_program_xattr(&attr, NULL, 0);

	}

	if (ret < 0) {

		ret = errno;

		cp = libbpf_strerror_r(ret, errmsg, sizeof(errmsg));