Commit 5bc3da35 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

thermal: intel: intel_soc_dts_iosf: Add helper for resetting trip points 



Because trip points are reset for each sensor in two places in the
same way, add a helper function for that to reduce code duplication
a bit.

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
parent 51f2aaf0

drivers/thermal/intel/intel_soc_dts_iosf.c

+9 −6
Original line number Diff line number Diff line
@@ -369,6 +369,12 @@ void intel_soc_dts_iosf_interrupt_handler(struct intel_soc_dts_sensors *sensors) 
}

EXPORT_SYMBOL_GPL(intel_soc_dts_iosf_interrupt_handler);



static void dts_trips_reset(struct intel_soc_dts_sensors *sensors, int dts_index)

{

	configure_trip(&sensors->soc_dts[dts_index], 0, 0, 0);

	configure_trip(&sensors->soc_dts[dts_index], 1, 0, 0);

}



struct intel_soc_dts_sensors *intel_soc_dts_iosf_init(

	enum intel_soc_dts_interrupt_type intr_type, int read_only_trip_count)

{
@@ -424,10 +430,8 @@ struct intel_soc_dts_sensors *intel_soc_dts_iosf_init( 
		remove_dts_thermal_zone(&sensors->soc_dts[i]);



err_reset_trips:

	for (i = 0; i < SOC_MAX_DTS_SENSORS; i++) {

		configure_trip(&sensors->soc_dts[i], 0, 0, 0);

		configure_trip(&sensors->soc_dts[i], 1, 0, 0);

	}

	for (i = 0; i < SOC_MAX_DTS_SENSORS; i++)

		dts_trips_reset(sensors, i);



	kfree(sensors);

	return ERR_PTR(ret);
@@ -440,8 +444,7 @@ void intel_soc_dts_iosf_exit(struct intel_soc_dts_sensors *sensors) 


	for (i = 0; i < SOC_MAX_DTS_SENSORS; ++i) {

		remove_dts_thermal_zone(&sensors->soc_dts[i]);

		configure_trip(&sensors->soc_dts[i], 0, 0, 0);

		configure_trip(&sensors->soc_dts[i], 1, 0, 0);

		dts_trips_reset(sensors, i);

	}

	kfree(sensors);

}