Commit 5b7b74b7 authored by Yangtao Li's avatar Yangtao Li Committed by Jaegeuk Kim
Browse files

f2fs: remove submit label in __submit_discard_cmd() 



Complaint from Matthew Wilcox in another similar place:

	"submit?  You don't submit anything at the 'submit' label.
	it should be called 'skip' or something.  But I think this
	is just badly written and you don't need a goto at all."

Let's remove submit label for readability.

Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Reviewed-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent d3b7b4af

fs/f2fs/segment.c

+3 −4
Original line number Diff line number Diff line
@@ -1143,13 +1143,12 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi, 
		if (time_to_inject(sbi, FAULT_DISCARD)) {

			f2fs_show_injection_info(sbi, FAULT_DISCARD);

			err = -EIO;

			goto submit;

		}

		} else {

			err = __blkdev_issue_discard(bdev,

					SECTOR_FROM_BLOCK(start),

					SECTOR_FROM_BLOCK(len),

					GFP_NOFS, &bio);

submit:

		}

		if (err) {

			spin_lock_irqsave(&dc->lock, flags);

			if (dc->state == D_PARTIAL)