Commit 5b72dafa authored by Randy Dunlap's avatar Randy Dunlap Committed by Hans de Goede
Browse files

platform/x86: dell: fix DELL_WMI_PRIVACY dependencies & build error 



When DELL_WMI=y, DELL_WMI_PRIVACY=y, and LEDS_TRIGGER_AUDIO=m, there
is a linker error since the LEDS trigger code is built as a loadable
module. This happens because DELL_WMI_PRIVACY is a bool that depends
on a tristate (LEDS_TRIGGER_AUDIO=m), which can be dangerous.

ld: drivers/platform/x86/dell/dell-wmi-privacy.o: in function `dell_privacy_wmi_probe':
dell-wmi-privacy.c:(.text+0x3df): undefined reference to `ledtrig_audio_get'

Fixes: 8af9fa37 ("platform/x86: dell-privacy: Add support for Dell hardware privacy")
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Perry Yuan <Perry.Yuan@dell.com>
Cc: Dell.Client.Kernel@dell.com
Cc: platform-driver-x86@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <mgross@linux.intel.com>
Link: https://lore.kernel.org/r/20210918044829.19222-1-rdunlap@infradead.org


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 3c3c8e88

drivers/platform/x86/dell/Kconfig

+1 −2
Original line number Diff line number Diff line
@@ -166,8 +166,7 @@ config DELL_WMI 


config DELL_WMI_PRIVACY

	bool "Dell WMI Hardware Privacy Support"

	depends on DELL_WMI

	depends on LEDS_TRIGGER_AUDIO

	depends on LEDS_TRIGGER_AUDIO = y || DELL_WMI = LEDS_TRIGGER_AUDIO

	help

	  This option adds integration with the "Dell Hardware Privacy"

	  feature of Dell laptops to the dell-wmi driver.