Commit 5b613df3 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

pinctrl: intel: No need to disable IRQs in the handler 



In IRQ handler interrupts are already disabled, hence no need
to repeat it. Even in the threaded case, which is disabled here,
it is not a problem because IRQ framework serializes descriptor
handling. Remove disabling IRQ part in the handler.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent 77e14126

drivers/pinctrl/intel/pinctrl-intel.c

+2 −3
Original line number Diff line number Diff line
@@ -1173,16 +1173,15 @@ static int intel_gpio_community_irq_handler(struct intel_pinctrl *pctrl, 
	for (gpp = 0; gpp < community->ngpps; gpp++) {

		const struct intel_padgroup *padgrp = &community->gpps[gpp];

		unsigned long pending, enabled, gpp_offset;

		unsigned long flags;



		raw_spin_lock_irqsave(&pctrl->lock, flags);

		raw_spin_lock(&pctrl->lock);



		pending = readl(community->regs + community->is_offset +

				padgrp->reg_num * 4);

		enabled = readl(community->regs + community->ie_offset +

				padgrp->reg_num * 4);



		raw_spin_unlock_irqrestore(&pctrl->lock, flags);

		raw_spin_unlock(&pctrl->lock);



		/* Only interrupts that are enabled */

		pending &= enabled;