Commit 5b469415 authored by Chengchang Tang's avatar Chengchang Tang
Browse files

RDMA/hns: Use one CQ bank per context 

driver inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IB30V8



----------------------------------------------------------------------

By forcing each context to use the same CQ bank. Ensure that there is
fixed mapping logic between all QP and CQ banks. Ensure that SQ, RQ,
and CQ can share the QPC cache in QMM to avoid the timer deadlock.

Currently, since the upload strategy for this issue(DTS2024032521959)
has not yet been clarified and it involves 920B/C, the patch is
currently marked as noup.

Fixes: 9e03dbea ("RDMA/hns: Fix CQ and QP cache affinity")
Signed-off-by: default avatarChengchang Tang <tangchengchang@huawei.com>
Signed-off-by: default avatarXinghai Cen <cenxinghai@h-partners.com>
parent e3c28592

drivers/infiniband/hw/hns/hns_roce_cq.c

+54 −3
Original line number Diff line number Diff line
@@ -37,6 +37,43 @@ 
#include "hns_roce_hem.h"

#include "hns_roce_common.h"



void hns_roce_put_cq_bankid_for_uctx(struct hns_roce_ucontext *uctx)

{

	struct hns_roce_dev *hr_dev = to_hr_dev(uctx->ibucontext.device);

	struct hns_roce_cq_table *cq_table = &hr_dev->cq_table;



	if (hr_dev->pci_dev->revision < PCI_REVISION_ID_HIP09)

		return;



	mutex_lock(&cq_table->bank_mutex);

	cq_table->ctx_num[uctx->cq_bank_id]--;

	mutex_unlock(&cq_table->bank_mutex);

}



void hns_roce_get_cq_bankid_for_uctx(struct hns_roce_ucontext *uctx)

{

	struct hns_roce_dev *hr_dev = to_hr_dev(uctx->ibucontext.device);

	struct hns_roce_cq_table *cq_table = &hr_dev->cq_table;

	u32 least_load = cq_table->ctx_num[0];

	u8 bankid = 0;

	u8 i;



	if (hr_dev->pci_dev->revision < PCI_REVISION_ID_HIP09)

		return;



	mutex_lock(&cq_table->bank_mutex);

	for (i = 1; i < HNS_ROCE_CQ_BANK_NUM; i++) {

		if (cq_table->ctx_num[i] < least_load) {

			least_load = cq_table->ctx_num[i];

			bankid = i;

		}

	}

	cq_table->ctx_num[bankid]++;

	mutex_unlock(&cq_table->bank_mutex);



	uctx->cq_bank_id = bankid;

}



static u8 get_least_load_bankid_for_cq(struct hns_roce_bank *bank)

{

	u32 least_load = bank[0].inuse;
@@ -55,7 +92,21 @@ static u8 get_least_load_bankid_for_cq(struct hns_roce_bank *bank) 
	return bankid;

}



static int alloc_cqn(struct hns_roce_dev *hr_dev, struct hns_roce_cq *hr_cq)

static u8 select_cq_bankid(struct hns_roce_dev *hr_dev, struct hns_roce_bank *bank,

			struct ib_udata *udata)

{

	struct hns_roce_ucontext *uctx = udata ?

		rdma_udata_to_drv_context(udata, struct hns_roce_ucontext,

					  ibucontext) : NULL;

	/* only apply for HIP09 and HIP10 now, and use bank 0 for kernel */

	if (hr_dev->pci_dev->revision >= PCI_REVISION_ID_HIP09)

		return uctx ? uctx->cq_bank_id : 0;



	return get_least_load_bankid_for_cq(bank);

}



static int alloc_cqn(struct hns_roce_dev *hr_dev, struct hns_roce_cq *hr_cq,

		     struct ib_udata *udata)

{

	struct hns_roce_cq_table *cq_table = &hr_dev->cq_table;

	struct hns_roce_bank *bank;
@@ -63,7 +114,7 @@ static int alloc_cqn(struct hns_roce_dev *hr_dev, struct hns_roce_cq *hr_cq) 
	int id;



	mutex_lock(&cq_table->bank_mutex);

	bankid = get_least_load_bankid_for_cq(cq_table->bank);

	bankid = select_cq_bankid(hr_dev, cq_table->bank, udata);

	bank = &cq_table->bank[bankid];



	id = ida_alloc_range(&bank->ida, bank->min, bank->max, GFP_KERNEL);
@@ -416,7 +467,7 @@ int hns_roce_create_cq(struct ib_cq *ib_cq, const struct ib_cq_init_attr *attr, 
		goto err_cq_buf;

	}



	ret = alloc_cqn(hr_dev, hr_cq);

	ret = alloc_cqn(hr_dev, hr_cq, udata);

	if (ret) {

		ibdev_err(ibdev, "failed to alloc CQN, ret = %d.\n", ret);

		goto err_cq_db;

drivers/infiniband/hw/hns/hns_roce_device.h

+4 −0
Original line number Diff line number Diff line
@@ -265,6 +265,7 @@ struct hns_roce_ucontext { 
	struct list_head list; /* link all uctx to uctx_list on hr_dev */

	pid_t pid; /* process id to which the uctx belongs */

	struct hns_dca_ctx_debugfs dca_dbgfs;

	u8 cq_bank_id;

};



struct hns_roce_pd {
@@ -592,6 +593,7 @@ struct hns_roce_cq_table { 
	struct hns_roce_hem_table	table;

	struct hns_roce_bank bank[HNS_ROCE_CQ_BANK_NUM];

	struct mutex			bank_mutex;

	u32 ctx_num[HNS_ROCE_CQ_BANK_NUM];

};



struct hns_roce_srq_table {
@@ -1476,4 +1478,6 @@ void hns_roce_add_unfree_mtr(struct hns_roce_mtr_node *pos, 
void hns_roce_free_unfree_mtr(struct hns_roce_dev *hr_dev);

int hns_roce_alloc_scc_param(struct hns_roce_dev *hr_dev);

void hns_roce_dealloc_scc_param(struct hns_roce_dev *hr_dev);

void hns_roce_put_cq_bankid_for_uctx(struct hns_roce_ucontext *uctx);

void hns_roce_get_cq_bankid_for_uctx(struct hns_roce_ucontext *uctx);

#endif /* _HNS_ROCE_DEVICE_H */

drivers/infiniband/hw/hns/hns_roce_main.c

+2 −0
Original line number Diff line number Diff line
@@ -598,6 +598,7 @@ static int hns_roce_alloc_ucontext(struct ib_ucontext *uctx, 
	mutex_unlock(&hr_dev->uctx_list_mutex);



	hns_roce_register_uctx_debugfs(hr_dev, context);

	hns_roce_get_cq_bankid_for_uctx(context);



	return 0;
@@ -634,6 +635,7 @@ static void hns_roce_dealloc_ucontext(struct ib_ucontext *ibcontext) 
	    hr_dev->caps.flags & HNS_ROCE_CAP_FLAG_QP_RECORD_DB)

		mutex_destroy(&context->page_mutex);



	hns_roce_put_cq_bankid_for_uctx(context);

	hns_roce_unregister_uctx_debugfs(context);



	hns_roce_unregister_udca(hr_dev, context);