Commit 5b32dd28 authored by Colin Ian King's avatar Colin Ian King Committed by Corey Minyard
Browse files

ipmi: kcs_bmc_aspeed: Fix less than zero comparison of a unsigned int 



The comparisons of the unsigned int hw_type to less than zero always
false because it is unsigned. Fix this by using an int for the
assignment and less than zero check.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 9d2df9a0ad80 ("ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Message-Id: <20210616162913.15259-1-colin.king@canonical.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent d0ec795c

drivers/char/ipmi/kcs_bmc_aspeed.c

+5 −3
Original line number Diff line number Diff line
@@ -301,13 +301,15 @@ static inline int aspeed_kcs_map_serirq_type(u32 dt_type) 
static int aspeed_kcs_config_upstream_irq(struct aspeed_kcs_bmc *priv, u32 id, u32 dt_type)

{

	unsigned int mask, val, hw_type;

	int ret;



	if (id > 15)

		return -EINVAL;



	hw_type = aspeed_kcs_map_serirq_type(dt_type);

	if (hw_type < 0)

		return hw_type;

	ret = aspeed_kcs_map_serirq_type(dt_type);

	if (ret < 0)

		return ret;

	hw_type = ret;



	priv->upstream_irq.mode = aspeed_kcs_irq_serirq;

	priv->upstream_irq.id = id;