Commit 5b209d1a authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5e: Avoid implicit modify hdr for decap drop rule 



Currently the driver adds implicit modify hdr action for
decap rules on tunnel devices if the port is an ovs port.
This is also done if the action is drop and makes the modify
hdr redundant and also the FW doesn't support it and will generate
a syndrome.

kernel: mlx5_core 0000:08:00.0: mlx5_cmd_check:777:(pid 102063): SET_FLOW_TABLE_ENTRY(0x936) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x8708c3)

Fix it by adding the implicit modify hdr only for fwd actions.

Fixes: b16eb3c8 ("net/mlx5: Support internal port as decap route device")
Fixes: 077cdda7 ("net/mlx5e: TC, Fix memory leak with rules with internal port")
Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarAriel Levkovich <lariel@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent de47db0c

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+2 −1
Original line number Diff line number Diff line
@@ -1414,7 +1414,8 @@ mlx5e_tc_add_fdb_flow(struct mlx5e_priv *priv, 
		if (err)

			goto err_out;



		if (!attr->chain && esw_attr->int_port) {

		if (!attr->chain && esw_attr->int_port &&

		    attr->action & MLX5_FLOW_CONTEXT_ACTION_FWD_DEST) {

			/* If decap route device is internal port, change the

			 * source vport value in reg_c0 back to uplink just in

			 * case the rule performs goto chain > 0. If we have a miss