Commit 5b17a497 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jakub Kicinski
Browse files

forcedeth: Fix an error handling path in nv_probe() 



If an error occures after calling nv_mgmt_acquire_sema(), it should be
undone with a corresponding nv_mgmt_release_sema() call.

Add it in the error handling path of the probe as already done in the
remove function.

Fixes: cac1c52c ("forcedeth: mgmt unit interface")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarZhu Yanjun <zyjzyj2000@gmail.com>
Link: https://lore.kernel.org/r/355e9a7d351b32ad897251b6f81b5886fcdc6766.1684571393.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6ca328e9

drivers/net/ethernet/nvidia/forcedeth.c

+1 −0
Original line number Diff line number Diff line
@@ -6138,6 +6138,7 @@ static int nv_probe(struct pci_dev *pci_dev, const struct pci_device_id *id) 
	return 0;



out_error:

	nv_mgmt_release_sema(dev);

	if (phystate_orig)

		writel(phystate|NVREG_ADAPTCTL_RUNNING, base + NvRegAdapterControl);

out_freering: