Commit 5afdd990 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Martin K. Petersen
Browse files

scsi: hpsa: Use the bitmap API to allocate bitmaps 

Use bitmap_zalloc()/bitmap_free() instead of hand-writing them. It is less
verbose and it improves the semantic.

Link: https://lore.kernel.org/r/5f975ef43f8b7306e4ac4e2e8ce4bcd53f6092bb.1658340441.git.christophe.jaillet@wanadoo.fr


Tested-by: default avatarDon Brace <don.brace@microchip.com>
Acked-by: default avatarDon Brace <don.brace@microchip.com>
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent de05e484

drivers/scsi/hpsa.c

+2 −4
Original line number Diff line number Diff line
@@ -8030,7 +8030,7 @@ static int hpsa_init_reset_devices(struct pci_dev *pdev, u32 board_id) 


static void hpsa_free_cmd_pool(struct ctlr_info *h)

{

	kfree(h->cmd_pool_bits);

	bitmap_free(h->cmd_pool_bits);

	h->cmd_pool_bits = NULL;

	if (h->cmd_pool) {

		dma_free_coherent(&h->pdev->dev,
@@ -8052,9 +8052,7 @@ static void hpsa_free_cmd_pool(struct ctlr_info *h) 


static int hpsa_alloc_cmd_pool(struct ctlr_info *h)

{

	h->cmd_pool_bits = kcalloc(DIV_ROUND_UP(h->nr_cmds, BITS_PER_LONG),

				   sizeof(unsigned long),

				   GFP_KERNEL);

	h->cmd_pool_bits = bitmap_zalloc(h->nr_cmds, GFP_KERNEL);

	h->cmd_pool = dma_alloc_coherent(&h->pdev->dev,

		    h->nr_cmds * sizeof(*h->cmd_pool),

		    &h->cmd_pool_dhandle, GFP_KERNEL);