Commit 5ab6177f authored by Corentin Labbe's avatar Corentin Labbe Committed by Herbert Xu
Browse files

crypto: sun4i-ss - handle BigEndian for cipher 



Ciphers produce invalid results on BE.
Key and IV need to be written in LE.

Fixes: 6298e948 ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarCorentin Labbe <clabbe@baylibre.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent b756f1c8

drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c

+6 −6
Original line number Diff line number Diff line
@@ -52,13 +52,13 @@ static int noinline_for_stack sun4i_ss_opti_poll(struct skcipher_request *areq) 


	spin_lock_irqsave(&ss->slock, flags);



	for (i = 0; i < op->keylen; i += 4)

		writel(*(op->key + i / 4), ss->base + SS_KEY0 + i);

	for (i = 0; i < op->keylen / 4; i++)

		writesl(ss->base + SS_KEY0 + i * 4, &op->key[i], 1);



	if (areq->iv) {

		for (i = 0; i < 4 && i < ivsize / 4; i++) {

			v = *(u32 *)(areq->iv + i * 4);

			writel(v, ss->base + SS_IV0 + i * 4);

			writesl(ss->base + SS_IV0 + i * 4, &v, 1);

		}

	}

	writel(mode, ss->base + SS_CTL);
@@ -223,13 +223,13 @@ static int sun4i_ss_cipher_poll(struct skcipher_request *areq) 


	spin_lock_irqsave(&ss->slock, flags);



	for (i = 0; i < op->keylen; i += 4)

		writel(*(op->key + i / 4), ss->base + SS_KEY0 + i);

	for (i = 0; i < op->keylen / 4; i++)

		writesl(ss->base + SS_KEY0 + i * 4, &op->key[i], 1);



	if (areq->iv) {

		for (i = 0; i < 4 && i < ivsize / 4; i++) {

			v = *(u32 *)(areq->iv + i * 4);

			writel(v, ss->base + SS_IV0 + i * 4);

			writesl(ss->base + SS_IV0 + i * 4, &v, 1);

		}

	}

	writel(mode, ss->base + SS_CTL);