Commit 5a7c4509 authored by Jason Yan's avatar Jason Yan Committed by David S. Miller
Browse files

net: mlx4: remove unneeded variable "err" in mlx4_en_ethtool_add_mac_rule() 



Fix the following coccicheck warning:

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1396:5-8: Unneeded
variable: "err". Return "0" on line 1411

Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 27ad2cd2

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c

+1 −2
Original line number Diff line number Diff line
@@ -1392,7 +1392,6 @@ static int mlx4_en_ethtool_add_mac_rule(struct ethtool_rxnfc *cmd, 
					struct mlx4_spec_list *spec_l2,

					unsigned char *mac)

{

	int err = 0;

	__be64 mac_msk = cpu_to_be64(MLX4_MAC_MASK << 16);



	spec_l2->id = MLX4_NET_TRANS_RULE_ID_ETH;
@@ -1407,7 +1406,7 @@ static int mlx4_en_ethtool_add_mac_rule(struct ethtool_rxnfc *cmd, 


	list_add_tail(&spec_l2->list, rule_list_h);



	return err;

	return 0;

}



static int mlx4_en_ethtool_add_mac_rule_by_ipv4(struct mlx4_en_priv *priv,