Commit 5a709a46 authored by Samuel Holland's avatar Samuel Holland Committed by Vinod Koul
Browse files

phy: rockchip-inno-usb2: Do not lock in bvalid IRQ handler 



Clearing the IRQ is atomic, so there is no need to hold the mutex.

Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
Tested-by: default avatarMichael Riesch <michael.riesch@wolfvision.net>
Link: https://lore.kernel.org/r/20220414032258.40984-4-samuel@sholland.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 656f7fcb

drivers/phy/rockchip/phy-rockchip-inno-usb2.c

+0 −4
Original line number Diff line number Diff line
@@ -905,13 +905,9 @@ static irqreturn_t rockchip_usb2phy_bvalid_irq(int irq, void *data) 
	if (!property_enabled(rphy->grf, &rport->port_cfg->bvalid_det_st))

		return IRQ_NONE;



	mutex_lock(&rport->mutex);



	/* clear bvalid detect irq pending status */

	property_enable(rphy->grf, &rport->port_cfg->bvalid_det_clr, true);



	mutex_unlock(&rport->mutex);



	rockchip_usb2phy_otg_sm_work(&rport->otg_sm_work.work);



	return IRQ_HANDLED;