Commit 5a5bc826 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpio: dwapb: Drop redundant check in dwapb_irq_set_type() 



For more than 15 years we may not get into ->irq_set_type()
without any meaningful type provided.

Drop redundant check in dwapb_irq_set_type().

See the commit e76de9f8 ("[PATCH] genirq: add SA_TRIGGER support")
out of curiosity.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent cc0f53d2

drivers/gpio/gpio-dwapb.c

+0 −3
Original line number Diff line number Diff line
@@ -297,9 +297,6 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type) 
	irq_hw_number_t bit = irqd_to_hwirq(d);

	unsigned long level, polarity, flags;



	if (type & ~IRQ_TYPE_SENSE_MASK)

		return -EINVAL;



	spin_lock_irqsave(&gc->bgpio_lock, flags);

	level = dwapb_read(gpio, GPIO_INTTYPE_LEVEL);

	polarity = dwapb_read(gpio, GPIO_INT_POLARITY);