Commit 5a243894 authored by Yang Yingliang's avatar Yang Yingliang Committed by Jakub Kicinski
Browse files

net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get() 



of_parse_phandle() will increase the refcount of 'pcs_node', so add
of_node_put() before return from a5psw_pcs_get().

Fixes: 888cdb89 ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220630014153.1888811-1-yangyingliang@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 34eff17e

drivers/net/dsa/rzn1_a5psw.c

+2 −0
Original line number Diff line number Diff line
@@ -917,12 +917,14 @@ static int a5psw_pcs_get(struct a5psw *a5psw) 
		}



		a5psw->pcs[reg] = pcs;

		of_node_put(pcs_node);

	}

	of_node_put(ports);



	return 0;



free_pcs:

	of_node_put(pcs_node);

	of_node_put(port);

	of_node_put(ports);

	a5psw_pcs_free(a5psw);