Commit 5a23ad65 authored by Oliver Upton's avatar Oliver Upton Committed by Marc Zyngier
Browse files

KVM: arm64: Prevent userspace from handling SMC64 arch range 



Though presently unused, there is an SMC64 view of the Arm architecture
calls defined by the SMCCC. The documentation of the SMCCC filter states
that the SMC64 range is reserved, but nothing actually prevents
userspace from applying a filter to the range.

Insert a range with the HANDLE action for the SMC64 arch range, thereby
preventing userspace from imposing filtering/forwarding on it.

Fixes: fb88707d ("KVM: arm64: Use a maple tree to represent the SMCCC filter")
Signed-off-by: default avatarOliver Upton <oliver.upton@linux.dev>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230408121732.3411329-2-oliver.upton@linux.dev
parent 0e5c9a9d

arch/arm64/kvm/hypercalls.c

+19 −6
Original line number Diff line number Diff line
@@ -121,12 +121,18 @@ static bool kvm_smccc_test_fw_bmap(struct kvm_vcpu *vcpu, u32 func_id) 
	}

}



#define SMCCC_ARCH_RANGE_BEGIN	ARM_SMCCC_VERSION_FUNC_ID

#define SMCCC_ARCH_RANGE_END				\

	ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL,		\

#define SMC32_ARCH_RANGE_BEGIN	ARM_SMCCC_VERSION_FUNC_ID

#define SMC32_ARCH_RANGE_END	ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL,		\

						   ARM_SMCCC_SMC_32,		\

						   0, ARM_SMCCC_FUNC_MASK)



#define SMC64_ARCH_RANGE_BEGIN	ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL,		\

						   ARM_SMCCC_SMC_64,		\

						   0, 0)

#define SMC64_ARCH_RANGE_END	ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL,		\

						   ARM_SMCCC_SMC_64,		\

						   0, ARM_SMCCC_FUNC_MASK)



static void init_smccc_filter(struct kvm *kvm)

{

	int r;
@@ -139,10 +145,17 @@ static void init_smccc_filter(struct kvm *kvm) 
	 * to the guest.

	 */

	r = mtree_insert_range(&kvm->arch.smccc_filter,

			       SMCCC_ARCH_RANGE_BEGIN, SMCCC_ARCH_RANGE_END,

			       SMC32_ARCH_RANGE_BEGIN, SMC32_ARCH_RANGE_END,

			       xa_mk_value(KVM_SMCCC_FILTER_HANDLE),

			       GFP_KERNEL_ACCOUNT);

	WARN_ON_ONCE(r);



	r = mtree_insert_range(&kvm->arch.smccc_filter,

			       SMC64_ARCH_RANGE_BEGIN, SMC64_ARCH_RANGE_END,

			       xa_mk_value(KVM_SMCCC_FILTER_HANDLE),

			       GFP_KERNEL_ACCOUNT);

	WARN_ON_ONCE(r);



}



static int kvm_smccc_set_filter(struct kvm *kvm, struct kvm_smccc_filter __user *uaddr)