Commit 5a0f663f authored by Yonghong Song's avatar Yonghong Song Committed by Alexei Starovoitov
Browse files

compiler_types: Define __rcu as __attribute__((btf_type_tag("rcu"))) 



Currently, without rcu attribute info in BTF, the verifier treats
rcu tagged pointer as a normal pointer. This might be a problem
for sleepable program where rcu_read_lock()/unlock() is not available.
For example, for a sleepable fentry program, if rcu protected memory
access is interleaved with a sleepable helper/kfunc, it is possible
the memory access after the sleepable helper/kfunc might be invalid
since the object might have been freed then. To prevent such cases,
introducing rcu tagging for memory accesses in verifier can help
to reject such programs.

To enable rcu tagging in BTF, during kernel compilation,
define __rcu as attribute btf_type_tag("rcu") so __rcu information can
be preserved in dwarf and btf, and later can be used for bpf prog verification.

Acked-by: default avatarKP Singh <kpsingh@kernel.org>
Acked-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: default avatarYonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/r/20221124053206.2373141-1-yhs@fb.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent f471748b

include/linux/compiler_types.h

+2 −1
Original line number Diff line number Diff line
@@ -49,7 +49,8 @@ static inline void __chk_io_ptr(const volatile void __iomem *ptr) { } 
# endif

# define __iomem

# define __percpu	BTF_TYPE_TAG(percpu)

# define __rcu

# define __rcu		BTF_TYPE_TAG(rcu)



# define __chk_user_ptr(x)	(void)0

# define __chk_io_ptr(x)	(void)0

/* context/locking */