Commit 59e477af authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

usb: gadget: f_uac2: remove redundant assignments to pointer i_feature 



Pointer i_feature is being initialized with a value and then immediately
re-assigned a new value in the next statement. Fix this by replacing the
the redundant initialization with the following assigned value.

Acked-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210804125907.111654-1-colin.king@canonical.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e21dd90e

drivers/usb/gadget/function/f_uac2.c

+4 −8
Original line number Diff line number Diff line
@@ -970,16 +970,12 @@ afunc_bind(struct usb_configuration *cfg, struct usb_function *fn) 
	std_as_in_if1_desc.iInterface = us[STR_AS_IN_ALT1].id;



	if (FUOUT_EN(uac2_opts)) {

		u8 *i_feature = (u8 *)out_feature_unit_desc;



		i_feature = (u8 *)out_feature_unit_desc +

		u8 *i_feature = (u8 *)out_feature_unit_desc +

				out_feature_unit_desc->bLength - 1;

		*i_feature = us[STR_FU_OUT].id;

	}

	if (FUIN_EN(uac2_opts)) {

		u8 *i_feature = (u8 *)in_feature_unit_desc;



		i_feature = (u8 *)in_feature_unit_desc +

		u8 *i_feature = (u8 *)in_feature_unit_desc +

				in_feature_unit_desc->bLength - 1;

		*i_feature = us[STR_FU_IN].id;

	}