Commit 59c2760b authored Jun 23, 2023 by Olivier Maignial Committed by sanglipeng Feb 22, 2024

mtd: spinand: toshiba: Fix ecc_get_status

stable inclusion
from stable-v5.10.190
commit 82dc2bffeabc4fb40e911ca708d2f46efb3c95c0
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I928UI

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=82dc2bffeabc4fb40e911ca708d2f46efb3c95c0

--------------------------------

commit 8544cda9 upstream.

Reading ECC status is failing.

tx58cxgxsxraix_ecc_get_status() is using on-stack buffer
for SPINAND_GET_FEATURE_OP() output. It is not suitable
for DMA needs of spi-mem.

Fix this by using the spi-mem operations dedicated buffer
spinand->scratchbuf.

See
spinand->scratchbuf:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/mtd/spinand.h?h=v6.3#n418
spi_mem_check_op():
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-mem.c?h=v6.3#n199



Fixes: 10949af1 ("mtd: spinand: Add initial support for Toshiba TC58CVG2S0H")
Cc: stable@vger.kernel.org
Signed-off-by: Olivier Maignial <olivier.maignial@hotmail.fr>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/DB4P250MB1032553D05FBE36DEE0D311EFE23A@DB4P250MB1032.EURP250.PROD.OUTLOOK.COM


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: sanglipeng <sanglipeng1@jd.com>

parent 42e27424

drivers/mtd/nand/spi/toshiba.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -73,7 +73,7 @@ static int tx58cxgxsxraix_ecc_get_status(struct spinand_device *spinand,
		{
		struct nand_device *nand = spinand_to_nand(spinand);
		u8 mbf = 0;
		struct spi_mem_op op = SPINAND_GET_FEATURE_OP(0x30, &mbf);
		struct spi_mem_op op = SPINAND_GET_FEATURE_OP(0x30, spinand->scratchbuf);

		switch (status & STATUS_ECC_MASK) {
		case STATUS_ECC_NO_BITFLIPS:
		@@ -92,7 +92,7 @@ static int tx58cxgxsxraix_ecc_get_status(struct spinand_device *spinand,
		if (spi_mem_exec_op(spinand->spimem, &op))
		return nanddev_get_ecc_requirements(nand)->strength;

		mbf >>= 4;
		mbf = *(spinand->scratchbuf) >> 4;

		if (WARN_ON(mbf > nanddev_get_ecc_requirements(nand)->strength \|\| !mbf))
		return nanddev_get_ecc_requirements(nand)->strength;