Commit 59ba1b2b authored by Rob Clark's avatar Rob Clark
Browse files

drm/msm/devfreq: Fix OPP refcnt leak 



Reported-by: default avatarDouglas Anderson <dianders@chromium.org>
Fixes: 9bc95570 ("drm/msm: Devfreq tuning")
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Tested-By: default avatarSteev Klimaszewski <steev@kali.org>
Reviewed-by: default avatarAkhil P Oommen <akhilpo@codeaurora.org>
Link: https://lore.kernel.org/r/20211105202021.181092-1-robdclark@gmail.com


Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent b4d25abf

drivers/gpu/drm/msm/msm_gpu_devfreq.c

+5 −0
Original line number Diff line number Diff line
@@ -20,6 +20,10 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq, 
	struct msm_gpu *gpu = dev_to_gpu(dev);

	struct dev_pm_opp *opp;



	/*

	 * Note that devfreq_recommended_opp() can modify the freq

	 * to something that actually is in the opp table:

	 */

	opp = devfreq_recommended_opp(dev, freq, flags);



	/*
@@ -28,6 +32,7 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq, 
	 */

	if (gpu->devfreq.idle_freq) {

		gpu->devfreq.idle_freq = *freq;

		dev_pm_opp_put(opp);

		return 0;

	}