Commit 59b7e210 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix null ndlp ptr dereference in abnormal exit path for GFT_ID 

An error case exit from lpfc_cmpl_ct_cmd_gft_id() results in a call to
lpfc_nlp_put() with a null pointer to a nodelist structure.

Changed lpfc_cmpl_ct_cmd_gft_id() to initialize nodelist pointer upon
entry.

Link: https://lore.kernel.org/r/20220819011736.14141-3-jsmart2021@gmail.com


Co-developed-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 439b9329

drivers/scsi/lpfc/lpfc_ct.c

+2 −5
Original line number Diff line number Diff line
@@ -1509,7 +1509,7 @@ lpfc_cmpl_ct_cmd_gft_id(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, 
	struct lpfc_sli_ct_request *CTrsp;

	int did;

	struct lpfc_nodelist *ndlp = NULL;

	struct lpfc_nodelist *ns_ndlp = NULL;

	struct lpfc_nodelist *ns_ndlp = cmdiocb->ndlp;

	uint32_t fc4_data_0, fc4_data_1;

	u32 ulp_status = get_job_ulpstatus(phba, rspiocb);

	u32 ulp_word4 = get_job_word4(phba, rspiocb);
@@ -1528,9 +1528,6 @@ lpfc_cmpl_ct_cmd_gft_id(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, 
		goto out;

	}



	/* Preserve the nameserver node to release the reference. */

	ns_ndlp = cmdiocb->ndlp;



	if (ulp_status == IOSTAT_SUCCESS) {

		/* Good status, continue checking */

		CTrsp = (struct lpfc_sli_ct_request *)outp->virt;