Commit 5995f746 authored by Cai Huoqing's avatar Cai Huoqing Committed by Kalle Valo
Browse files

wifi: rtw89: Remove redundant pci_clear_master 



Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
	u16 pci_command;

	pci_read_config_word(dev, PCI_COMMAND, &pci_command);
	if (pci_command & PCI_COMMAND_MASTER) {
		pci_command &= ~PCI_COMMAND_MASTER;
		pci_write_config_word(dev, PCI_COMMAND, pci_command);
	}

	pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.

Signed-off-by: default avatarCai Huoqing <cai.huoqing@linux.dev>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Acked-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230323112613.7550-5-cai.huoqing@linux.dev
parent 47515664

drivers/net/wireless/realtek/rtw89/pci.c

+0 −1
Original line number Diff line number Diff line
@@ -2694,7 +2694,6 @@ static int rtw89_pci_claim_device(struct rtw89_dev *rtwdev, 
static void rtw89_pci_declaim_device(struct rtw89_dev *rtwdev,

				     struct pci_dev *pdev)

{

	pci_clear_master(pdev);

	pci_disable_device(pdev);

}