Commit 59715cff authored by Nirmoy Das's avatar Nirmoy Das Committed by Alex Deucher
Browse files

drm/amdgpu: use IS_ERR for debugfs APIs 

debugfs APIs returns encoded error so use
IS_ERR for checking return value.

v2: return PTR_ERR(ent)

References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686


Signed-off-by: default avatarNirmoy Das <nirmoy.das@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-By: default avatarShashank Sharma <shashank.sharma@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent bbb36348

drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c

+4 −6
Original line number Diff line number Diff line
@@ -1696,20 +1696,18 @@ int amdgpu_debugfs_init(struct amdgpu_device *adev) 
	struct dentry *ent;

	int r, i;







	ent = debugfs_create_file("amdgpu_preempt_ib", 0600, root, adev,

				  &fops_ib_preempt);

	if (!ent) {

	if (IS_ERR(ent)) {

		DRM_ERROR("unable to create amdgpu_preempt_ib debugsfs file\n");

		return -EIO;

		return PTR_ERR(ent);

	}



	ent = debugfs_create_file("amdgpu_force_sclk", 0200, root, adev,

				  &fops_sclk_set);

	if (!ent) {

	if (IS_ERR(ent)) {

		DRM_ERROR("unable to create amdgpu_set_sclk debugsfs file\n");

		return -EIO;

		return PTR_ERR(ent);

	}



	/* Register debugfs entries for amdgpu_ttm */

drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c

+2 −2
Original line number Diff line number Diff line
@@ -428,8 +428,8 @@ int amdgpu_debugfs_ring_init(struct amdgpu_device *adev, 
	ent = debugfs_create_file(name,

				  S_IFREG | S_IRUGO, root,

				  ring, &amdgpu_debugfs_ring_fops);

	if (!ent)

		return -ENOMEM;

	if (IS_ERR(ent))

		return PTR_ERR(ent);



	i_size_write(ent->d_inode, ring->ring_size + 12);

	ring->ent = ent;