Commit 596690e9 authored Aug 05, 2021 by Heiner Kallweit Committed by David S. Miller Aug 06, 2021

ethtool: return error from ethnl_ops_begin if dev is NULL



Julian reported that after d43c65b0 Coverity complains about a
missing check whether dev is NULL in ethnl_ops_complete().
There doesn't seem to be any valid case where dev could be NULL when
calling ethnl_ops_begin(), therefore return an error if dev is NULL.

Fixes: d43c65b0 ("ethtool: runtime-resume netdev parent in ethnl_ops_begin")
Reported-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5c0418ed

net/ethtool/netlink.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -35,7 +35,7 @@ int ethnl_ops_begin(struct net_device *dev)
		int ret;

		if (!dev)
		return 0;
		return -ENODEV;

		if (dev->dev.parent)
		pm_runtime_get_sync(dev->dev.parent);
		@@ -61,7 +61,7 @@ int ethnl_ops_begin(struct net_device *dev)

		void ethnl_ops_complete(struct net_device *dev)
		{
		if (dev && dev->ethtool_ops->complete)
		if (dev->ethtool_ops->complete)
		dev->ethtool_ops->complete(dev);

		if (dev->dev.parent)