Unverified Commit 5947b272 authored by Zheyu Ma's avatar Zheyu Ma Committed by Mark Brown
Browse files

ASoC: SOF: Intel: Check the bar size before remapping 



The driver should use the pci_resource_len() to get the actual length of
pci bar, and compare it with the expect value. If the bar size is too
small (such as a broken device), the driver should return an error.

Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
Link: https://lore.kernel.org/r/20220409143950.2570186-1-zheyuma97@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 90b76a3c

sound/soc/sof/intel/pci-tng.c

+5 −1
Original line number Diff line number Diff line
@@ -75,7 +75,11 @@ static int tangier_pci_probe(struct snd_sof_dev *sdev) 


	/* LPE base */

	base = pci_resource_start(pci, desc->resindex_lpe_base) - IRAM_OFFSET;

	size = PCI_BAR_SIZE;

	size = pci_resource_len(pci, desc->resindex_lpe_base);

	if (size < PCI_BAR_SIZE) {

		dev_err(sdev->dev, "error: I/O region is too small.\n");

		return -ENODEV;

	}



	dev_dbg(sdev->dev, "LPE PHY base at 0x%x size 0x%x", base, size);

	sdev->bar[DSP_BAR] = devm_ioremap(sdev->dev, base, size);