Unverified Commit 591825fb authored by Javier Martinez Canillas's avatar Javier Martinez Canillas
Browse files

dt-bindings: display: ssd1307fb: Remove default width and height values 



A default resolution in the ssd130x driver isn't set to an arbitrary 96x16
anymore. Instead is set to a width and height that's controller dependent.

The datasheets for the chips describes the following display resolutions:

 - SH1106:  132 x 64 Dot Matrix OLED/PLED
 - SSD1305: 132 x 64 Dot Matrix OLED/PLED
 - SSD1306: 128 x 64 Dot Matrix OLED/PLED
 - SSD1307: 128 x 39 Dot Matrix OLED/PLED
 - SSD1309: 128 x 64 Dot Matrix OLED/PLED

Update DT schema to reflect what the driver does and make its users aware.

Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230609170941.1150941-3-javierm@redhat.com
parent f1f288d0

Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml

+24 −4
Original line number Diff line number Diff line
@@ -49,15 +49,15 @@ properties: 


  solomon,height:

    $ref: /schemas/types.yaml#/definitions/uint32

    default: 16

    description:

      Height in pixel of the screen driven by the controller

      Height in pixel of the screen driven by the controller.

      The default value is controller-dependent.



  solomon,width:

    $ref: /schemas/types.yaml#/definitions/uint32

    default: 96

    description:

      Width in pixel of the screen driven by the controller

      Width in pixel of the screen driven by the controller.

      The default value is controller-dependent.



  solomon,page-offset:

    $ref: /schemas/types.yaml#/definitions/uint32
@@ -157,6 +157,10 @@ allOf: 
            const: sinowealth,sh1106

    then:

      properties:

        width:

          default: 132

        height:

          default: 64

        solomon,dclk-div:

          default: 1

        solomon,dclk-frq:
@@ -171,6 +175,10 @@ allOf: 
              - solomon,ssd1305

    then:

      properties:

        width:

          default: 132

        height:

          default: 64

        solomon,dclk-div:

          default: 1

        solomon,dclk-frq:
@@ -185,6 +193,10 @@ allOf: 
              - solomon,ssd1306

    then:

      properties:

        width:

          default: 128

        height:

          default: 64

        solomon,dclk-div:

          default: 1

        solomon,dclk-frq:
@@ -199,6 +211,10 @@ allOf: 
              - solomon,ssd1307

    then:

      properties:

        width:

          default: 128

        height:

          default: 39

        solomon,dclk-div:

          default: 2

        solomon,dclk-frq:
@@ -215,6 +231,10 @@ allOf: 
              - solomon,ssd1309

    then:

      properties:

        width:

          default: 128

        height:

          default: 64

        solomon,dclk-div:

          default: 1

        solomon,dclk-frq: