Unverified Commit 58f01c7f authored by Tom Rix's avatar Tom Rix Committed by Mark Brown
Browse files

ASoC: codecs: lpass-wsa-macro: handle unexpected input 



Static analysis reports this problem

lpass-wsa-macro.c:1732:6: warning: Array subscript is undefined
        if (wsa->ec_hq[ec_tx]) {
            ^~~~~~~~~~~~~~~~~

The happens because 'ec_tx' is never initialized and there is
no default in switch statement that sets ec_tx.  Add a default
case that returns an error before the array is accessed.

Signed-off-by: default avatarTom Rix <trix@redhat.com>
Reviewed-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210430142117.3272772-1-trix@redhat.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1d122dd3

sound/soc/codecs/lpass-wsa-macro.c

+4 −0
Original line number Diff line number Diff line
@@ -1727,6 +1727,10 @@ static int wsa_macro_enable_echo(struct snd_soc_dapm_widget *w, 
		val = val & CDC_WSA_RX_MIX_TX1_SEL_MASK;

		ec_tx = (val >> CDC_WSA_RX_MIX_TX1_SEL_SHFT) - 1;

		break;

	default:

		dev_err(component->dev,	"%s: Invalid shift %u\n",

			__func__, w->shift);

		return -EINVAL;

	}



	if (wsa->ec_hq[ec_tx]) {