Commit 58b5fb00 authored by Michael Ellerman's avatar Michael Ellerman Committed by Benjamin Herrenschmidt
Browse files

powerpc/perf: Reject EBB events which specify a sample_type 



Although we already block EBB events which request sampling using
sample_period, technically it's possible for an event to set sample_type
but not sample_period.

Nothing terrible will happen if an EBB event does specify sample_type,
but it signals a major confusion on the part of userspace, and so we do
them the favor of rejecting it.

Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent c2e37a26

arch/powerpc/perf/core-book3s.c

+5 −2
Original line number Diff line number Diff line
@@ -503,8 +503,11 @@ static int ebb_event_check(struct perf_event *event) 
		if (!leader->attr.pinned || !leader->attr.exclusive)

			return -EINVAL;



		if (event->attr.inherit || event->attr.sample_period ||

		    event->attr.enable_on_exec || event->attr.freq)

		if (event->attr.freq ||

		    event->attr.inherit ||

		    event->attr.sample_type ||

		    event->attr.sample_period ||

		    event->attr.enable_on_exec)

			return -EINVAL;

	}