Commit 58a74c6f authored by Bernard Zhao's avatar Bernard Zhao Committed by Daniel Vetter
Browse files

drm/via: fix assignment in if condition 



Fix check_patch.pl warning:
ERROR: do not use assignment in if condition
+                       if ((HALCYON_HEADER2 == (cmd = *buf)) &&

ERROR: do not use assignment in if condition
+                       if (HALCYON_HEADER2 == (cmd = *buf))

Signed-off-by: default avatarBernard Zhao <bernard@vivo.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201118114021.105502-1-bernard@vivo.com
parent b1246bd4

drivers/gpu/drm/via/via_verifier.c

+4 −3
Original line number Diff line number Diff line
@@ -1001,8 +1001,8 @@ via_verify_command_stream(const uint32_t * buf, unsigned int size, 
			state = via_check_vheader6(&buf, buf_end);

			break;

		case state_command:

			if ((HALCYON_HEADER2 == (cmd = *buf)) &&

			    supported_3d)

			cmd = *buf;

			if ((cmd == HALCYON_HEADER2) && supported_3d)

				state = state_header2;

			else if ((cmd & HALCYON_HEADER1MASK) == HALCYON_HEADER1)

				state = state_header1;
@@ -1064,7 +1064,8 @@ via_parse_command_stream(struct drm_device *dev, const uint32_t *buf, 
			state = via_parse_vheader6(dev_priv, &buf, buf_end);

			break;

		case state_command:

			if (HALCYON_HEADER2 == (cmd = *buf))

			cmd = *buf;

			if (cmd == HALCYON_HEADER2)

				state = state_header2;

			else if ((cmd & HALCYON_HEADER1MASK) == HALCYON_HEADER1)

				state = state_header1;