Commit 589ccd8b authored by Doug Ledford's avatar Doug Ledford
Browse files

RDMA/bnxt_re: Fix static checker warning 



If there is ever any error while creating srq->umem, we return that
error, we don't store it in srq->umem, so any check of srq->umem for
IS_ERR is pointless.  Further, checking udata is unnecessary as
srq->umem is always either NULL or valid, without respect to udata.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent e7996a9a

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+2 −5
Original line number Diff line number Diff line
@@ -1314,7 +1314,7 @@ int bnxt_re_destroy_srq(struct ib_srq *ib_srq) 
		return rc;

	}



	if (srq->umem && !IS_ERR(srq->umem))

	if (srq->umem)

		ib_umem_release(srq->umem);

	kfree(srq);

	atomic_dec(&rdev->srq_count);
@@ -1430,11 +1430,8 @@ struct ib_srq *bnxt_re_create_srq(struct ib_pd *ib_pd, 
	return &srq->ib_srq;



fail:

	if (udata && srq->umem && !IS_ERR(srq->umem)) {

	if (srq->umem)

		ib_umem_release(srq->umem);

		srq->umem = NULL;

	}



	kfree(srq);

exit:

	return ERR_PTR(rc);