Commit 588a25e0 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/s3cfb: Use fbdev I/O helpers 



Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
	* use _IOMEM_ in commit message
v2:
	* updated to use _IOMEM_ tokens

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarHelge Deller <deller@gmx.de>
Cc: Jingoo Han <jingoohan1@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-38-tzimmermann@suse.de
parent d88e49ad

drivers/video/fbdev/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -1653,9 +1653,7 @@ config FB_S3C 
	tristate "Samsung S3C framebuffer support"

	depends on FB && HAVE_CLK && HAS_IOMEM

	depends on ARCH_S3C64XX || COMPILE_TEST

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_HELPERS

	help

	  Frame buffer driver for the built-in FB controller in the Samsung

	  SoC line such as the S3C6400 and S3C6410.

drivers/video/fbdev/s3c-fb.c

+1 −3
Original line number Diff line number Diff line
@@ -1038,13 +1038,11 @@ static int s3c_fb_ioctl(struct fb_info *info, unsigned int cmd, 


static const struct fb_ops s3c_fb_ops = {

	.owner		= THIS_MODULE,

	FB_DEFAULT_IOMEM_OPS,

	.fb_check_var	= s3c_fb_check_var,

	.fb_set_par	= s3c_fb_set_par,

	.fb_blank	= s3c_fb_blank,

	.fb_setcolreg	= s3c_fb_setcolreg,

	.fb_fillrect	= cfb_fillrect,

	.fb_copyarea	= cfb_copyarea,

	.fb_imageblit	= cfb_imageblit,

	.fb_pan_display	= s3c_fb_pan_display,

	.fb_ioctl	= s3c_fb_ioctl,

};