Commit 586e154f authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Luiz Augusto von Dentz
Browse files

Bluetooth: hci_ldisc: Fix tty_set_termios() return value assumptions 



tty_set_termios() never returns anything else than 0. Make the debug
prints to look directly into the new termios instead to check CRTSCTS
state.

Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent 7c2b2d2d

drivers/bluetooth/hci_ldisc.c

+4 −4
Original line number Diff line number Diff line
@@ -323,9 +323,9 @@ void hci_uart_set_flow_control(struct hci_uart *hu, bool enable) 
		/* Disable hardware flow control */

		ktermios = tty->termios;

		ktermios.c_cflag &= ~CRTSCTS;

		status = tty_set_termios(tty, &ktermios);

		tty_set_termios(tty, &ktermios);

		BT_DBG("Disabling hardware flow control: %s",

		       status ? "failed" : "success");

		       (tty->termios.c_cflag & CRTSCTS) ? "failed" : "success");



		/* Clear RTS to prevent the device from sending */

		/* Most UARTs need OUT2 to enable interrupts */
@@ -357,9 +357,9 @@ void hci_uart_set_flow_control(struct hci_uart *hu, bool enable) 
		/* Re-enable hardware flow control */

		ktermios = tty->termios;

		ktermios.c_cflag |= CRTSCTS;

		status = tty_set_termios(tty, &ktermios);

		tty_set_termios(tty, &ktermios);

		BT_DBG("Enabling hardware flow control: %s",

		       status ? "failed" : "success");

		       !(tty->termios.c_cflag & CRTSCTS) ? "failed" : "success");

	}

}