Commit 582d4ad4 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mauro Carvalho Chehab
Browse files

media: tc358746: select CONFIG_GENERIC_PHY 

The tc358746 driver selects CONFIG_GENERIC_PHY_MIPI_DPHY and links to
that, but this fails when CONFIG_GENERIC_PHY is disabled, because Kbuild
then never enters the drivers/phy directory for building object files:

ERROR: modpost: "phy_mipi_dphy_get_default_config_for_hsclk" [drivers/media/i2c/tc358746.ko] undefined!

Add an explicit 'select GENERIC_PHY' here to ensure that the directory
is entered, and add another dependency on that symbol so make it
more obvious what is going on if another driver has the same problem,
as this will produce a Kconfig warning.

Link: https://lore.kernel.org/linux-media/20230623152318.2276816-1-arnd@kernel.org


Fixes: 80a21da3 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarMarco Felsch <m.felsch@pengutronix.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent d78b9d66

drivers/media/i2c/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -1305,6 +1305,7 @@ config VIDEO_TC358746 
	select VIDEO_V4L2_SUBDEV_API

	select MEDIA_CONTROLLER

	select V4L2_FWNODE

	select GENERIC_PHY

	select GENERIC_PHY_MIPI_DPHY

	select REGMAP_I2C

	help

drivers/phy/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ config GENERIC_PHY 


config GENERIC_PHY_MIPI_DPHY

	bool

	depends on GENERIC_PHY

	help

	  Generic MIPI D-PHY support.