Commit 582ab24e authored by Hans de Goede's avatar Hans de Goede Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: pci: Set "linux,phy_charger_detect" property on some Bay Trail boards 



Some Android x86 tablets with a Bay Trail (BYT) SoC and a Crystal Cove
PMIC, which does not support charger-detection, rely on the TUSB1211 phy
for charger-detection.

Windows tablets with the same SoC + PMIC often use an extra chip for
charger-detection like the FSA831A. But since on Android tablets
the designers already need to add a TUSB1211 phy to support device/gadget
mode the phy is used to do charger-detection instead.

These Android x86 tablets can be identified by the unique combination of
a Bay Trail SoC (already checked for by PCI-ids) + a Crystal Cove PMIC +
not using the standard ACPI battery and ac drivers. Where as on Windows
tablets the standard ACPI battery and ac drivers will be used on BYT
boards with a Crystal Cove PMIC.

Set a special kernel-internal (so not part of the dt-bindings)
"linux,phy_charger_detect" property on these boards, which tells the
tusb1210 driver to enable charger-detection.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220213130524.18748-5-hdegoede@redhat.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e285cb40

drivers/usb/dwc3/dwc3-pci.c

+24 −0
Original line number Diff line number Diff line
@@ -119,6 +119,14 @@ static const struct property_entry dwc3_pci_intel_properties[] = { 
	{}

};



static const struct property_entry dwc3_pci_intel_phy_charger_detect_properties[] = {

	PROPERTY_ENTRY_STRING("dr_mode", "peripheral"),

	PROPERTY_ENTRY_BOOL("snps,dis_u2_susphy_quirk"),

	PROPERTY_ENTRY_BOOL("linux,phy_charger_detect"),

	PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"),

	{}

};



static const struct property_entry dwc3_pci_mrfld_properties[] = {

	PROPERTY_ENTRY_STRING("dr_mode", "otg"),

	PROPERTY_ENTRY_STRING("linux,extcon-name", "mrfld_bcove_pwrsrc"),
@@ -161,6 +169,10 @@ static const struct software_node dwc3_pci_intel_swnode = { 
	.properties = dwc3_pci_intel_properties,

};



static const struct software_node dwc3_pci_intel_phy_charger_detect_swnode = {

	.properties = dwc3_pci_intel_phy_charger_detect_properties,

};



static const struct software_node dwc3_pci_intel_mrfld_swnode = {

	.properties = dwc3_pci_mrfld_properties,

};
@@ -228,6 +240,18 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc, 
				gpiod_put(gpio);

				usleep_range(10000, 11000);

			}



			/*

			 * Some Android tablets with a Crystal Cove PMIC

			 * (INT33FD), rely on the TUSB1211 phy for charger

			 * detection. These can be identified by them _not_

			 * using the standard ACPI battery and ac drivers.

			 */

			if (acpi_dev_present("INT33FD", "1", 2) &&

			    acpi_quirk_skip_acpi_ac_and_battery()) {

				dev_info(&pdev->dev, "Using TUSB1211 phy for charger detection\n");

				swnode = &dwc3_pci_intel_phy_charger_detect_swnode;

			}

		}

	}