Commit 5827b168 authored by Oleksij Rempel's avatar Oleksij Rempel Committed by David S. Miller
Browse files

net: phy: c45: migrate to genphy_c45_write_eee_adv() 



Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv().

It should work as before except write operation to the EEE adv registers
will be done only if some EEE abilities was detected.

If some driver will have a regression, related driver should provide own
.get_features callback. See micrel.c:ksz9477_get_features() as example.

Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9b01c885

drivers/net/phy/phy-c45.c

+10 −1
Original line number Diff line number Diff line
@@ -262,7 +262,11 @@ int genphy_c45_an_config_aneg(struct phy_device *phydev) 
	linkmode_and(phydev->advertising, phydev->advertising,

		     phydev->supported);



	changed = genphy_config_eee_advert(phydev);

	ret = genphy_c45_write_eee_adv(phydev, phydev->supported_eee);

	if (ret < 0)

		return ret;

	else if (ret)

		changed = true;



	if (genphy_c45_baset1_able(phydev))

		return genphy_c45_baset1_an_config_aneg(phydev);
@@ -968,6 +972,11 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev) 
		}

	}



	/* This is optional functionality. If not supported, we may get an error

	 * which should be ignored.

	 */

	genphy_c45_read_eee_abilities(phydev);



	return 0;

}

EXPORT_SYMBOL_GPL(genphy_c45_pma_read_abilities);