Commit 580c6104 authored by Miklos Szeredi's avatar Miklos Szeredi
Browse files

ovl: fix uninitialized pointer read in ovl_lookup_real_one() 



One error path can result in release_dentry_name_snapshot() being called
before "name" was initialized by take_dentry_name_snapshot().

Fix by moving the release_dentry_name_snapshot() to immediately after the
only use.

Reported-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 9b91b6b0

fs/overlayfs/export.c

+1 −1
Original line number Diff line number Diff line
@@ -392,6 +392,7 @@ static struct dentry *ovl_lookup_real_one(struct dentry *connected, 
	 */

	take_dentry_name_snapshot(&name, real);

	this = lookup_one_len(name.name.name, connected, name.name.len);

	release_dentry_name_snapshot(&name);

	err = PTR_ERR(this);

	if (IS_ERR(this)) {

		goto fail;
@@ -406,7 +407,6 @@ static struct dentry *ovl_lookup_real_one(struct dentry *connected, 
	}



out:

	release_dentry_name_snapshot(&name);

	dput(parent);

	inode_unlock(dir);

	return this;