Commit 580aa8e4 authored by Chenyi Qiang's avatar Chenyi Qiang Committed by Aichun Shi
Browse files

KVM: X86: Reset the vcpu->run->flags at the beginning of vcpu_run 

mainline inclusion
from mainline-v5.12-rc1
commit 15aad3be
category: feature
feature: KVM Bus Lock VM Exit
bugzilla: https://gitee.com/openeuler/intel-kernel/issues/I5RJCB
CVE: N/A
Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/


commit/?id=15aad3be

Intel-SIG: commit 15aad3be ("KVM: X86: Reset the vcpu->run->flags at the beginning of vcpu_run")

-------------------------------------

KVM: X86: Reset the vcpu->run->flags at the beginning of vcpu_run

Reset the vcpu->run->flags at the beginning of kvm_arch_vcpu_ioctl_run.
It can avoid every thunk of code that needs to set the flag clear it,
which increases the odds of missing a case and ending up with a flag in
an undefined state.

Signed-off-by: default avatarChenyi Qiang <chenyi.qiang@intel.com>
Message-Id: <20201106090315.18606-3-chenyi.qiang@intel.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarAichun Shi <aichun.shi@intel.com>
parent b733e0a1

arch/x86/kvm/x86.c

+5 −1
Original line number Diff line number Diff line
@@ -8403,12 +8403,15 @@ static void post_kvm_run_save(struct kvm_vcpu *vcpu) 
	struct kvm_run *kvm_run = vcpu->run;



	kvm_run->if_flag = (kvm_get_rflags(vcpu) & X86_EFLAGS_IF) != 0;

	kvm_run->flags = is_smm(vcpu) ? KVM_RUN_X86_SMM : 0;



	kvm_run->cr8 = kvm_get_cr8(vcpu);

	kvm_run->apic_base = kvm_get_apic_base(vcpu);

	kvm_run->ready_for_interrupt_injection =

		pic_in_kernel(vcpu->kvm) ||

		kvm_vcpu_ready_for_interrupt_injection(vcpu);



	if (is_smm(vcpu))

		kvm_run->flags |= KVM_RUN_X86_SMM;

}



static void update_cr8_intercept(struct kvm_vcpu *vcpu)
@@ -9537,6 +9540,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu) 


	vcpu_load(vcpu);

	kvm_sigset_activate(vcpu);

	kvm_run->flags = 0;

	kvm_load_guest_fpu(vcpu);



	if (unlikely(vcpu->arch.mp_state == KVM_MP_STATE_UNINITIALIZED)) {