Commit 57eb5e1c authored by Jiri Olsa's avatar Jiri Olsa Committed by Alexei Starovoitov
Browse files

bpf: Fix uprobe_multi get_pid_task error path 



Dan reported Smatch static checker warning due to missing error
value set in uprobe multi link's get_pid_task error path.

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/bpf/c5ffa7c0-6b06-40d5-aca2-63833b5cd9af@moroto.mountain/


Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Reviewed-by: default avatarSong Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230915101420.1193800-1-jolsa@kernel.org


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent dca7acd8

kernel/trace/bpf_trace.c

+3 −1
Original line number Diff line number Diff line
@@ -3223,9 +3223,11 @@ int bpf_uprobe_multi_link_attach(const union bpf_attr *attr, struct bpf_prog *pr 
		rcu_read_lock();

		task = get_pid_task(find_vpid(pid), PIDTYPE_PID);

		rcu_read_unlock();

		if (!task)

		if (!task) {

			err = -ESRCH;

			goto error_path_put;

		}

	}



	err = -ENOMEM;