Commit 57e4bc8a authored by Sam Ravnborg's avatar Sam Ravnborg
Browse files

video: fbdev: sstfb: Updated logging to fix set but not used warnings 



Fix set but not used warnings by introducing no_printk variants
for the internal logging system for this driver.

Fix a new warning that popped up now that logging was checked for
correct printf format strings.

A more invasive fix had been to replace all the internal logging with
standard logging primitives - thats for another day.

v2:
  - Update subject (Lee)

Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Alex Dewar <alex.dewar90@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-20-sam@ravnborg.org
parent 9b028f48

drivers/video/fbdev/sstfb.c

+1 −1
Original line number Diff line number Diff line
@@ -1390,7 +1390,7 @@ static int sstfb_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	        fix->smem_start, info->screen_base,

	        fix->smem_len >> 20);



	f_ddprintk("regbase_virt: %#lx\n", par->mmio_vbase);

	f_ddprintk("regbase_virt: %p\n", par->mmio_vbase);

	f_ddprintk("membase_phys: %#lx\n", fix->smem_start);

	f_ddprintk("fbbase_virt: %p\n", info->screen_base);

include/video/sstfb.h

+2 −2
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ 
#  define SST_DEBUG_FUNC 1

#  define SST_DEBUG_VAR  1

#else

#  define dprintk(X...)

#  define dprintk(X...)		no_printk(X)

#  define SST_DEBUG_REG  0

#  define SST_DEBUG_FUNC 0

#  define SST_DEBUG_VAR  0
@@ -48,7 +48,7 @@ 
#if (SST_DEBUG_FUNC > 1)

#  define f_ddprintk(X...)	dprintk(" " X)

#else

#  define f_ddprintk(X...)

#  define f_ddprintk(X...)	no_printk(X)

#endif

#if (SST_DEBUG_FUNC > 2)

#  define f_dddprintk(X...)	dprintk(" " X)