Commit 57e20d68 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Stephen Boyd
Browse files

clk: fixed-rate: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-11-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 6f149b65

drivers/clk/clk-fixed-rate.c

+2 −4
Original line number Diff line number Diff line
@@ -196,14 +196,12 @@ void __init of_fixed_clk_setup(struct device_node *node) 
}

CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);



static int of_fixed_clk_remove(struct platform_device *pdev)

static void of_fixed_clk_remove(struct platform_device *pdev)

{

	struct clk_hw *hw = platform_get_drvdata(pdev);



	of_clk_del_provider(pdev->dev.of_node);

	clk_hw_unregister_fixed_rate(hw);



	return 0;

}



static int of_fixed_clk_probe(struct platform_device *pdev)
@@ -234,7 +232,7 @@ static struct platform_driver of_fixed_clk_driver = { 
		.of_match_table = of_fixed_clk_ids,

	},

	.probe = of_fixed_clk_probe,

	.remove = of_fixed_clk_remove,

	.remove_new = of_fixed_clk_remove,

};

builtin_platform_driver(of_fixed_clk_driver);

#endif